search

instamatic-dev / instamatic

Python program for automated electron diffraction data collection
https://instamatic.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
57 stars 25 forks source link

fei_microscope missing getMagnificationRanges #24

Closed thomasaarholt closed 4 years ago

thomasaarholt commented 4 years ago

Looks like there was one more thing needed to get the fei_microscope working, which was adding a getMagnificationRanges method. Currently I've just made it return an empty dict, but I'm sure there's a better return value.

Edit: In the context of the other issues, I fixed this first. I'm just reporting it last since I was able to easily bypass it.

stefsmeets commented 4 years ago

Good point! I will have a look at it.

stefsmeets commented 4 years ago

Can you tell me when this happened? Because it seems like this is only accessed when doing the autoconfig.

thomasaarholt commented 4 years ago

Ah yes, that makes sense. Since I was having trouble (in the other issue), I decided to reinstall everything after your merged PR yesterday(install from source). I used the autoconfig to set things up. Can't quite remember the exact details, but what you are describing makes sense.