search

instamatic-dev / instamatic

Python program for automated electron diffraction data collection
https://instamatic.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
56 stars 25 forks source link

Why not support setObjectiveLenseFine and setObjectiveLenseCoarse #86

Closed Binary-Vanguard-12138 closed 5 days ago

Binary-Vanguard-12138 commented 1 week ago

There are several parameters that we only have a getter function, but do not have a setter function. E.g. In the getObjectiveLenseFine function of jeol controller, it calls self.lens3.GetOLf() function. I guess it probably also has the SetOLf function. So why don't we provide a setter function for the ObjectiveLenseFine parameter? Does the COM library not have a SetOLf function?

Binary-Vanguard-12138 commented 1 week ago

@stefsmeets

stefsmeets commented 1 week ago

Hi @Binary-Vanguard-12138 it's sometimes not that simple, some values are easy to read, but complex to set. If you can test and confirm that your solution works I'm happy to take a PR on this.