search

instana / instana-agent-operator

A Kubernetes operator to install and manage the Instana agent.
https://www.instana.com
Apache License 2.0
46 stars 21 forks source link

Enhancement request to support agent on masters #40

Closed jferr closed 2 years ago

jferr commented 4 years ago

Note: We are an instana customer and I have submitted this request also via instana support

It would be a great addition to have an option in the operators crd to choose whether to install agents on masters. Something like install_agentonmaster: True

Since the daemonset is created by and managed by the operator it seems cleaner to include this in the operator and our infrastructure as code would be much cleaner (we have the operator crd configuration yaml checked into git)

Here's my workaround...I have a jenkins job where after I apply the crd yaml I run this...so it's not a huge deal but would be a great addition.

cat <<EOF > dspatch.yaml
spec:
  template:
    spec:
      tolerations:
        - key: "node-role.kubernetes.io/master"
          effect: "NoSchedule"
          operator: "Exists"
EOF

kubectl -n instana-agent patch ds instana-agent -p "$(cat dspatch.yaml)"
mdonkers commented 2 years ago

Hi,

Our new 2.0.0 version of the Operator allows for the same exact configuration as our Helm charts. Where its possible to define tolerations and affinity: https://github.com/instana/helm-charts/tree/main/instana-agent#configuration-reference

Does this cover your needs?