search

instana / instana-agent-puppet

Instana agent puppet module
https://www.instana.com/
Apache License 2.0
0 stars 6 forks source link

Main class name does not match module name #2

Open ghost opened 6 years ago

ghost commented 6 years ago

The module name is "agent" (according to the metadata.json) whereas the name of the class in the init.pp is "instana_agent". This offends against the puppet module specification and leads to problems e.g. when using r10k for module deployment. I would suggest to rename the module to "instana_agent" (because "agent" is a very generic name).

demikl commented 5 years ago

As far as I understand this problem, instana-agent is parsed as instana/agent as can be seen on https://forge.puppet.com/instana/agent/readme.

A better approach, in my opinion, would be : instana-instana_agent.