instana / instana-grafana-datasource

🔭 Grafana datasource plugin for Instana
https://grafana.com/plugins/instana-datasource
Apache License 2.0
38 stars 20 forks source link

getVersion should only be called if a valid Instana URL has been configured #107

Closed d0ugal closed 5 months ago

d0ugal commented 2 years ago

Every time I go to create a new Instana datasource this error pops up.

2022-06-07T16:35:31,036305842+01:00

Looking in my dev tools I can see a request is being made to https://HOSTNAME/undefined/api/instana/version

I suspect this is becauseoptions.url isn't set here yet. https://github.com/instana/instana-grafana-datasource/blob/6c4b6db927f93581c9a2d6ee2ca3dbe42143904f/src/util/request_handler.ts#L9

Sarathsgck12 commented 5 months ago

The issue will be resolved as part of the new V4.0.0