instana / instana-grafana-datasource

🔭 Grafana datasource plugin for Instana
https://grafana.com/plugins/instana-datasource
Apache License 2.0
38 stars 20 forks source link

Migrating API key from jsonData to secureJsonData #134

Closed Sarathsgck12 closed 8 months ago

Sarathsgck12 commented 8 months ago

Why?

All secure information should be stored in secureJsonData as opposed to jsonData. API key is currently part of the jsonData but it should be migrated. Considering this would be a breaking change to the existing model, it would be a good idea to introduce the field now as part of secureJsonData , while still supporting the old format.

What?

The current implementation includes the API key within the jsonData. To enhance security, the recommendation is to migrate the API key from jsonData to secureJsonData. This involves introducing a new 'apiToken' field within secureJsonData specifically for storing the API key. To maintain compatibility with the old format, it is noted that 'apiToken' is currently present in both jsonData and `secureJsonData'.

link to cards: https://instana.kanbanize.com/ctrl_board/206/cards/150887/details/