Breaking change version 4.0.0

Sarathsgck12 commented 8 months ago

Why?

Bump to a major version of the plugin (V4.0.0)

What?

The API token, currently stored in jsonData, is now migrated to secureJsonData starting from version 4.0.0. This is a breaking change, and existing users must reauthenticate their datasources.
Authentication now only takes place over the data source proxy method. Use-proxy via authentication is the only option in our datasource plugin so make use-proxy 'true' by default
Adding a new button named 'Reset Api Token' : Once credentials are saved, the API Token is stored on the server. Users have the option to reset the API Token using the provided reset key Button.

Screenshots

link to cards: https://instana.kanbanize.com/ctrl_board/206/cards/155270/details/

Daniel-Ebert commented 8 months ago

Hi there, just one suggestion for Air-Gapped environments, could you maybe add a configuration option to at least "ignore"ssl-cert-validation/ or even add the ability to define your CA Cert in Grafana, similarly to many other data sources where this is possible? I know you could also inject the right CA certificate in a Grafana Container Deployment, but if this is not much work, it'd be very handy :)

Before, this was possible by running the Data source without the proxy mode, when the custom Certificate Authority is trusted in the air gapped environment anyway.

Best regards

Daniel

sophiaxu0424 commented 7 months ago

LGTM, please tested all the on localhost before merging.

Sarathsgck12 commented 7 months ago

Hi Daniel,

The issue lies in the fact that the datasource requires a backend plugin on Grafana to incorporate the suggested comments.

instana / instana-grafana-datasource