instana / instana-grafana-datasource

🔭 Grafana datasource plugin for Instana
https://grafana.com/plugins/instana-datasource
Apache License 2.0
38 stars 20 forks source link

Update metric definitions and improve metric retrieval #5

Closed bripkens closed 6 years ago

bripkens commented 6 years ago

This PR…

I recommend looking at this with ignored whitespace changes :)

https://github.com/instana/instana-grafana-datasource/pull/5/files?utf8=%E2%9C%93&diff=split&w=1

Screenshots

Query string parameters used for the search APIs:

screen shot 2018-06-19 at 16 00 23

New items within the form:

screen shot 2018-06-19 at 16 01 17
JeroenSoeters commented 6 years ago

Had a discussion with Raphael and we thought it might be better to move the "New Application Model" button to the datasource settings instead of requiring the user to provide it with every query as this will be either enabled for the tenant unit or not. We don't expect users to be switching back and forth.

bripkens commented 6 years ago

Moved it to datasource configuration. This should address all the open remarks.