search

instana / instana-grafana-datasource

🔭 Grafana datasource plugin for Instana
https://grafana.com/plugins/instana-datasource
Apache License 2.0
38 stars 20 forks source link

Fix incorrect labels being shown for custom metrics in JVM/MicroMeter… #67

Closed xpmatteo closed 4 years ago

xpmatteo commented 4 years ago

I'm trying to show custom metrics from Spring Boot apps. The dropdown only shows an endless list of "Custom Micrometer counter" and "Custom Micrometer timer" that make it impossible to find the metric you're looking for (there are 1000+ in my case).

The fix is to show the "label", not the "description", because for some reason MicroMeter does not generate useful descriptions.

xpmatteo commented 4 years ago

This is how it looks without the fix

image

This is how it looks with the fix

image

As you can see, without the fix, most entries in the dropdown are just named "Custom Micrometer Gauge/Counter", and this makes it very difficult to find the metric you want

Dalje-et commented 4 years ago

LGTM! Thanks for you PR! Greatly appreciated!