Decorate errors with non-enumerable properties

[jonathansamines]

When this library is enabled, seems like http errors gets decorated with the current request information if available.

See:

• https://github.com/instana/nodejs-sensor/blob/master/src/tracing/clsHooked/context.js#L110
• https://github.com/instana/nodejs-sensor/blob/master/src/tracing/clsHooked/context.js#L161
• https://github.com/instana/nodejs-sensor/blob/master/src/tracing/clsHooked/context.js#L186

However, if for some reason, an application which prints the error (e.g in an express error handler), with a method that inspects all enumerable properties, then the current request object may be printed, and that may be a problem for a couple of reasons:

• Users could be using JSON.stringify which by default don't limit the recursion levels and it may cause recursion calls problems with request which has circular references
• The request object may container sensitive information, (sessions identifiers, users identifiers, or other secret information that developers may attach to it)

Would it make sense to change those properties to be non enumerable by default?

[basti1302]

I think we can get rid of attaching the context to the error object entirely. Thanks for bringing it up. A fix will land in v1.50.1.

[jonathansamines]

@basti1302 Thanks for the quick response. Will give the new version a try.