search

instana / python-sensor

:snake: Python Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
68 stars 30 forks source link

[OTel] Pika instrumentation #614

Closed pvital closed 1 day ago

pvital commented 1 week ago

Test coverage: 98%

pvital commented 3 days ago

Can we move all the imports inside the try block so that if pika is not present we can just completely avoid importing everything else?

All of them are inside the try-except block. Could you please re-check it?

GSVarsha commented 2 days ago

All of them are inside the try-except block. Could you please re-check it?

I meant these ones.

pvital commented 2 days ago

I meant these ones.

Got it. We did not follow this pattern at the beginning of the instrumentation migration, but I guess we can follow it now. I will change it and let you know.