instana / python-sensor

:snake: Python Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
69 stars 31 forks source link

[OTel] quick fix #637

Closed pvital closed 1 month ago

pvital commented 1 month ago
GSVarsha commented 1 month ago

Span duration and start_time when recording. Following the Instana Tracing Specification, the span ts must express the span's start as milliseconds since the Unix epoch, and the span d must be the duration of the span in milliseconds.

But that's why we are converting them from nano seconds to milli seconds here, right?

pvital commented 1 month ago

Looks good to me, goodbye MySQL errors 🚀

Sorry, @CagriYonca, but it will be there for a while. I read the wrong line of the documentation, and the calculation is correct, as mentioned by @GSVarsha.

I am canceling this PR.