search

instana / python-sensor

:snake: Python Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
69 stars 31 forks source link

Fix OTel header inject values. #644

Closed pvital closed 1 month ago

pvital commented 1 month ago

Fix OTel header inject values (Part 1)

Instana's Tracer Specification claims the X-INSTANA-T and X-INSTANA-S values injected in returned headers must be 16 lowercase hexadecimal characters.

Integration test results:

Before:

  2 passing (11s)
  42 failing

After:

  14 passing (30s)
  30 failing
pvital commented 1 month ago

We might have to adapt tracestate and Server-Timing headers as well.

You are right. That will demand some extra work since almost all header settings are made in each instrumentation code. I will update the PR and let you know.