search

instana / ruby-sensor

💎 Ruby Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
26 stars 25 forks source link

Pass OJ options in to dump/load calls instead of setting them as defa… #133

Closed jordan0day closed 5 years ago

jordan0day commented 5 years ago

…ults.

I ran into an issue adding the instana gem to an existing system which was also using OJ, but without requiring strict mode set. This seems like something maybe the agent doesn't necessarily want to set system-wide, but only for its own calls to OJ?

I'm pretty out-of-practice with Ruby, so not sure if a module constant is the right thing to do here?

pglombardo commented 5 years ago

That's interesting - I would have assumed the default set would have been scoped to the gem. I'll take a closer look soon and aim to merge. thanks @jordan0day