search

instana / ruby-sensor

💎 Ruby Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
26 stars 25 forks source link

Fix error in action controller has rails handler #141

Closed brucec5 closed 5 years ago

brucec5 commented 5 years ago

We were noticing NoMethodErrors being raised from this line. It looks like has_rails_handler? should have exception as an argument.

Also, this updates a call to Instana.logger.debug to build its log message within a block. This makes it so that we don't have to build the log message if our log level isn't debug.

pglombardo commented 5 years ago

Thanks @brucec5 - looks good. I'll aim to merge/release this soon.

I also like the log message in a block - I'm going to do some testing with this.

pglombardo commented 5 years ago

This has been released in gem 1.9.6: https://github.com/instana/ruby-sensor/releases/tag/1.9.6