instana / ruby-sensor

💎 Ruby Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
26 stars 25 forks source link

Set a service name for the EC2 Metadata Service. #167

Closed hmadison closed 4 years ago

hmadison commented 4 years ago

The EC2 Metadata Service is hosted at a bogon ip (169.254.170.2) and is used by the Ruby AWS SDK to access instance credentails via STS. It has started showing up as an Unmonitored HTTP Span in our traces around the time that Build 162 was released.

Per the documentationa around service naming, I belive this change should resolve the issue.

Documentation:

pglombardo commented 4 years ago

Hi @hmadison - thanks for pointing this out. We've made quite a few improvements with automatic service naming. Are these calls still showing up as Unmonitored for you?

This code change is a fair improvement but really should be done in the Instana dashboard so it covers all languages and supported components universally(and not directly in this Ruby sensor).

If this still is an issue for you, please file a ticket so we can consider adding this service naming rule in.

I'm going to close this ticket as this change shouldn't be done here but feel free to ping me for anything remaining questions/issues.