instana / ruby-sensor

💎 Ruby Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
26 stars 25 forks source link

Instana::Rack - Fix handling of a string status (convert to integer) #171

Closed pglombardo closed 4 years ago

pglombardo commented 4 years ago

This fixes a case where a Rack span may have been marked as errored because previous middleware in the stack may have passed a string status (not integer).

This seems to be valid according to the Rack Spec.

We also add a bunch of 404 style tests to validate the case where this issue was originally seen.