search

instana / ruby-sensor

💎 Ruby Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
26 stars 25 forks source link

Fix process memory metric UOM #288

Closed rafaeldriutti closed 1 year ago

rafaeldriutti commented 1 year ago

Currently the sensor reports process memory usage in bytes for Linux, and in Kilobytes for macos. Then the UI shows memory usage in Gigabytes instead of megabytes. This makes the sensor return always a value in KB. I also updated the specfile so it reflects current ruby version requirements (>2.4) This fixes #283 and #287

github-actions[bot] commented 1 year ago

❌ @rafaeldriutti the signed-off-by was not found in the following 2 commits:

📝 What should I do to fix it?

All proposed commits should include a sign-off in their messages, ideally at the end.

❔ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:

By making a contribution to this project, I certify that:

a. The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

b. The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

c. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

d. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'
Ferenc- commented 1 year ago

Hi,

Thank you for taking the initative and sending a PR, we appreciate such valuable contributions. Please check the latest v1.209.4 release, which contains a slightly different fix for the same problem.