github-actions[bot]
commented
1 year ago ❌ @basti1302 the signed-off-by was not found in the following 2 commits:
- https://github.com/instana/ruby-sensor/commit/213bc65f3f05ad30a6214b5752c4bf0662874e81: chore: fix spelling of W3C trace context related terms
- https://github.com/instana/ruby-sensor/commit/278462eacae9f77339c949c9d90db241f5ea009a: test: clean up W3C test cases with respect to X-INSTANA-L
📝 What should I do to fix it?
All proposed commits should include a sign-off in their messages, ideally at the end.
❔ Why it is required
The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
By making a contribution to this project, I certify that:
a. The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
b. The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
c. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
d. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.
This is my commit message
Signed-off-by: Random Developer <randomdeveloper@example.com>Git even has a -s command line option to append this automatically to your commit message:
$ git commit -s -m 'This is my commit message'
basti1302
The new test case in the tracer test suite is also failing for Ruby. (At first I thought it would not but that was only because the test suite accidentally ran an outdated set of test cases. This is fixed now.)
This PR should fix it. (Not tested locally with the test suite yet, though.)Update 2023-05-22: This PR fixes that. I have tested this locally with the tracer test suite with the changes from this branch.