search

instana / ruby-sensor

💎 Ruby Distributed Tracing & Metrics Sensor for Instana
https://www.instana.com/
MIT License
26 stars 25 forks source link

fix: The spec doesn't set upper limit for ec=1 if code>=500 #350

Closed Ferenc- closed 10 months ago

Ferenc- commented 10 months ago

Quote from the spec:

For HTTP exit and entry spans alike, if a full request/response cycle has happened (which implies that an HTTP status code is present): If the HTTP status code is >= 500, the associated span MUST be marked as an error via span.ec.

This means that there is no upper limit, and this should apply to custom status codes as well, which might be above 511, or even 599.