search

instance-oom / ngx-markdown-editor

Angular markdown editor based on ace editor
http://lon-yang.github.io/markdown-editor/
Apache License 2.0
174 stars 48 forks source link

fix(toolbar): hide btn group if empty #144

Closed Lqvrent closed 1 year ago

Lqvrent commented 1 year ago

Problem: In the toolbar, when a btn group was empty, it was still leaving his border to connect two groups. Fix: Added conditions in the btn group elements.

Also, I added a "CustomBtns" possibility to the hideIcons options, to hide it's btn group (usefull when you don't want custom buttons).

instance-oom commented 1 year ago

It should be better to use css to control it.

Lqvrent commented 1 year ago

It should be better to use css to control it.

I don't understand to be honest. Can you explain more ? Is it using CSS in my own app ? The scoped CSS don't allow me to really fix this problem If it's inside the package, I don't really see how to implement that