Serialize scalar enums - Githubissues

instant-labs / instant-xml

11 stars 3 forks source link

Serialize scalar enums #24

Closed rsdy closed 1 year ago

rsdy commented 1 year ago

This patchset resolves #18 .

The proc macro will panic if:

The enum is not marked as scalar with #[xml(scalar)]
The variant has a non-literal discriminant (e.g. 1 + 1, or some other const expr)
The #[xml(scalar)] attribute is used for variants (only permitted on the enum)
A variant has both a discriminant and a #[xml(rename = "value")] attribute.

djc commented 1 year ago

So I'd like the third commit squashed into the second one, since it's not logically separate.

On rustfmt vs macros, can you try and see what actually changes about the formatting when you remove the #[skip] attributes? So far it's been fine in this crate (and in my experience on other crates).