search

instantOS / instantNIX

instantOS tools packaged for the Nix package manager (and NixOS)
MIT License
32 stars 7 forks source link

Change instantdata userconfig #22

Closed ppenguin closed 3 years ago

ppenguin commented 3 years ago

Changed to a fork of instantdata which offers the option --get-userconfig-dir=<confdir> to enable to use personal overrides for files normally only obtained from ...-instantDotfiles-unstable/share/instantdotfiles/<confdir>.

Added one use case that overrides the appmenu config to ~/.config/rofi if available.

(This can be used to fix the fontsize issues mentioned in https://github.com/instantOS/instantOS/issues/90)

SCOTT-HAMILTON commented 3 years ago

Just made a test suite for instantdata. It just checks that instantdata gives the good system paths. To run the test, use nix-build -A tests.instantdata with the latest commit from dev.

Could you update the pkgs/tests/instantdata/default.nix file accordingly ? If any help is needed, don't hesitate to ask here.

con-f-use commented 3 years ago

Can we instead get that repo into the instantOS project here on github? @SCOTT-HAMILTON @ppenguin

SCOTT-HAMILTON commented 3 years ago

Sure, but I think that only @paperbenni can give me the permissions (temporarly) to move my repo to instantOS.

con-f-use commented 3 years ago

Sure, but I think that only @paperbenni can give me the permissions (temporarly) to move my repo to instantOS.

@SCOTT-HAMILTON any progress on that? What should we do with this PR?

SCOTT-HAMILTON commented 3 years ago

I'll merge to move on. We will transfer instantdata later.

Anyway thanks a lot for your work and patience @ppenguin ! It really took too long to be merged and this kind of delay shouldn't happen in the future if we don't want people to be discouraged every time they open a new PR.