instantOS / instantWM

The window manager for instantOS
MIT License
334 stars 38 forks source link

`instantwm -v` does nothing #125

Closed luphoria closed 1 year ago

luphoria commented 1 year ago

Running instantwm -v prints the following: usage: instantwm [-v]

when it should probably print the same as instantwm --version: instantwm-instantOS beta6-96-g3ba7b - Build Fri, Sep 16 2022, 15:10:09 +0200 on instantospc

paperbenni commented 1 year ago

This has been implemented

con-f-use commented 1 year ago

Lower case -v should absolutely not print the version. It is commonly the flag to increase verbosity. Capital -V is officially the short option for --version. If you ever introduce logging in instantWM this will cause confusion (:wink: ) and backward-compatibility issues.

luphoria commented 1 year ago

Lower case -v should absolutely not print the version. It is commonly the flag to increase verbosity. Capital -V is officially the short option for --version. If you ever introduce logging in instantWM this will cause confusion (wink ) and backward-compatibility issues.

This is a completely separate approach to the issue at hand. Mostly the issue is the usage print: image How this is approached is a design choice (and not my place to make one), but currently it prints usage: instantwm [-v] (lowercase). In my personal opinion and experience, lowercase v is generally version and not verbose; but, again, that's not my choice to make.

con-f-use commented 1 year ago

Agreed, the usage string should be correct and mention all the user-facing options.

As to what is more common, here are some common tools, that use -v for verbosity and/or -V for version, you might recognize a few :wink: :

ssh, python, rustc, head, tail, less, more, rm, mv, cp, mkdir, wget, curl, netstat, htop, rg, ag, awk, man, lzma, bzip, locale, locate, fschk, mkfs, tar, telnet, gpg, openssl, udev, mount, zip, host, lvm, sudo, which, xauth, xz, youtube-dl, zfs

To just name a few. It's also POSIX recommendation.

luphoria commented 1 year ago

126 fixes what I was referencing. And yeah, seems you're right about -v vs -V :zany_face: