Fix rooms bug where we were sending events before receiving a join room ack

instantdb / instant

The realtime client-side database

https://instantdb.com

Apache License 2.0

5.85k stars 137 forks source link

Fix rooms bug where we were sending events before receiving a join room ack #190

Closed markyfyi closed 5 days ago

markyfyi commented 1 week ago

Previously, we had a race condition, where we set presence before we got an ack for join room. Since all messages are parallelized on the server, this would mean that we could 'handle' a presence before the join-room finished.

We now handle the room lifetime better on the client

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
instant-www	❌ Failed (Inspect)			Sep 10, 2024 10:42pm

github-actions[bot] commented 6 days ago

View Vercel preview at instant-www-js-fix-rooms-jsv.vercel.app.