search

instantiations / es_compression

Compression framework for Dart providing FFI implementations for Brotli, Lz4, Zstd (Zstandard) with ready-to-use prebuilt binaries for Win/Linux/Mac.
https://www.instantiations.com
BSD 3-Clause "New" or "Revised" License
41 stars 8 forks source link

add lib prefix for android #29

Closed mejdi14 closed 2 years ago

mejdi14 commented 2 years ago

when building a release version for android, gradle ignore all libs which their names doesn't start with 'lib' this pull request covers this use case

sethloco commented 2 years ago

Hi,

Thanks for your work on this. I would certainly be happy to pull in this change. How did you build the libraries? If it was the blob builder, then I'm wondering if I need to also update the CMakeLists.txt file to make sure that 'lib' is added to the prefix for Android builds. Somewhere in this area?: https://github.com/instantiations/es_compression/blob/master/tool/blob_builder/CMakeLists.txt#L307

Thoughts?

mejdi14 commented 2 years ago

Hi, i used the pre-built libs, these changes were made just to make sure that an app using this package will successfully link to the Android libs regardless of their names, updating that CMakeLists file will be a great addition too

sethloco commented 2 years ago

Hi, I'm working on finishing up a release of our commercial product, but after that I'll merge this in along with a version bump I'll do for zstd. New version should be published in May. Thank you again for this contribution