instantlinux / docker-tools

Docker tools for developer productivity & entertainment
Apache License 2.0
272 stars 89 forks source link

Issue #86 set stopsignal in haproxy-keepalived image #124

Closed instantlinux closed 1 year ago

instantlinux commented 1 year ago

Summary of Changes

Define the STOPSIGNAL in haproxy-keepalived image.

Why is this change being made?

Kubernetes must be told explicitly what signal to use; by default the stopsignal is SIGUSR1 and it should be SIGTERM.

How was this tested? How can the reviewer verify your testing?

Local test: built image, launched under helm, then helm delete haproxy-keepalived. Can now see the log message Received SIGTERM prior to container shutdown. (Still not working fully, though - the VIP isn't getting torn down despite the script apparently reaching the correct function.)

Completion checklist