Add `data-instant` attribute to whitelist an external link

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%

https://instant.page

MIT License

6.04k stars 205 forks source link

Add `data-instant` attribute to whitelist an external link #13

Closed batbyR closed 5 years ago

batbyR commented 5 years ago

Following up from Issue #5

Whitelist select external links

bashbaugh commented 5 years ago

What about adding data-instant-allow-external body option to allow all external links to be whitelisted?

batbyR commented 5 years ago

Hi @scitronboy,

I am waiting for an explanation from @dieulot for the external link ban. Maybe it's a bad idea to prefetch external links we don't know, potentially consuming a lot of bandwith.

If not, I would add your body option to my pull request 👍

bashbaugh commented 5 years ago

Yes, but for small websites like personal blogs where every link is created by you specifically for your content, then external prefetching might be good. Do you think so?

dieulot commented 5 years ago

👍