search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.04k stars 205 forks source link

Doesn’t work with Rocket Loader #14

Closed alesmaze closed 5 years ago

alesmaze commented 5 years ago

When I have a Rocket Loader (Cloudflare) on the domain, the script doesn’t work.

image

ibrokemycomputer commented 5 years ago

I've seen a lot of strange issues with Cloudflare + caching. I haven't heard of Rocket Loader but would love to look into this. From what I can see Rocket Loader supposedly is added to your domain/hosting - any chance you can provide the URL or confirm this isnt an issue after Cloudflare's heavy cache has updated?

pmjcreations commented 5 years ago

I have seen the same issue, and I have disabled Rocket Loader.

When we enable Rocket Loader, Cloudflare will insert the JS file on the fly no matter what caching setup we have within the Cloudflare

alesmaze commented 5 years ago

Yes, that's why I put this JavaScript into my custom.js, but not everyone has this option.

dieulot commented 5 years ago

Could someone point me to a site with Rocket Loader and instant.page? I set up a basic website with Rocket Loader, and it works.

dieulot commented 5 years ago

Closing this issue as I can’t reproduce it. If someone points me to a site where a bug happens with Rocket Loader + instant.page I’ll reopen it.