search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.04k stars 205 forks source link

Check if user is not on a slow connection #25

Closed batbyR closed 5 years ago

batbyR commented 5 years ago

Following up from Issue #24

Check if user uses 2g connection or data saver mode.

kurtextrem commented 5 years ago

Imo it doesn't make sense to stop preloading on a slow network. Especially there a big benefit can be had. Unlike Quicklink, instant.page is 50:50 sure, that the user clicks on the link that is getting preloaded.

We might increase the delay slightly however.

futtta commented 5 years ago

But does the 50:50 apply to desktop (mouseOver) or mobile (which uses the touch events which my gut tell me are not as efficient in predicting a link being followed)?

kurtextrem commented 5 years ago

Good question. Let's wait for @dieulot

dieulot commented 5 years ago

I’m not sure I have data on the touchstart/click ratio, at least I can’t find it right now. I don’t think it’s worse; users scroll and thus trigger touchstart often but it’s not often on a link on most pages.

In any case, preloading one HTML page on 2G usually won’t clog up the connection, so we’ll leave it.

I was open to disabling it when Data Saver mode is enabled but I’m not anymore for now, sorry.