search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.04k stars 205 forks source link

* Add whitelist mode (enabled via adding `data-instant-whitelist-mode` to body) #29

Closed PikachuEXE closed 5 years ago

PikachuEXE commented 5 years ago

Fixes #18

atilacamurca commented 5 years ago

Tell me if I understand correctly. This new configuration is as follows?

<html>
  <body data-instant-whitelist-mode>
    <a href="#1" data-instant>Instant link</a>
    <a href="#2">Not an Instant link</a>
  </body>
</html>
PikachuEXE commented 5 years ago

@atilacamurca Yup the only thing new is the data-instant-whitelist-mode on body

PikachuEXE commented 5 years ago

Any more comments?

PikachuEXE commented 5 years ago

Is this good to be merged?

PikachuEXE commented 5 years ago

Any update for this change?

PikachuEXE commented 5 years ago

Would this PR be merged?

dieulot commented 5 years ago

Sorry for letting this hanging.

This won’t get merged, it needs tests. Also we wouldn’t use data-instant-whitelist-mode, probably data-instant-whitelist. Also I’m not 100% sure yet that I want a whitelist.

I also want to revamp the tests before adding tests for a whitelist mode, because the arguments to pass currently are a mess.

So I’m going to do it myself. Thanks for your PR though.

PikachuEXE commented 5 years ago

OK would you create a draft PR so interest people can follow? Just a way to subscribe to update instead of every update in this repo