Closed PikachuEXE closed 5 years ago
Tell me if I understand correctly. This new configuration is as follows?
<html>
<body data-instant-whitelist-mode>
<a href="#1" data-instant>Instant link</a>
<a href="#2">Not an Instant link</a>
</body>
</html>
@atilacamurca
Yup the only thing new is the data-instant-whitelist-mode
on body
Any more comments?
Is this good to be merged?
Any update for this change?
Would this PR be merged?
Sorry for letting this hanging.
This won’t get merged, it needs tests. Also we wouldn’t use data-instant-whitelist-mode, probably data-instant-whitelist. Also I’m not 100% sure yet that I want a whitelist.
I also want to revamp the tests before adding tests for a whitelist mode, because the arguments to pass currently are a mess.
So I’m going to do it myself. Thanks for your PR though.
OK would you create a draft PR so interest people can follow? Just a way to subscribe to update instead of every update in this repo
Fixes #18