search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.04k stars 205 forks source link

Minify... #49

Closed MattWilcox closed 4 years ago

MattWilcox commented 4 years ago

This is an awesome project, but every one I've used it on and then had a co-worker run PageSpeed Insights had deducted points and thrown warnings about this not being minified...

Any chance of hosting / providing a minified version?

dieulot commented 4 years ago

Hi, currently it’s not minified because it fits in a single TCP packet (≤1.4kB) so there would be no advantage. When I add more features and the compressed script size exceeds 1.4kB I will minify.

MattWilcox commented 4 years ago

It makes perfect sense, but because Insights doesn't care, its still having an effect on the pagespeed score, which effects SEO negatively.

I know this isn't a technical issue; but it's still not good for anyone using the script and wanting it to not negatively effect their website's ranking (however small).

kkmuffme commented 4 years ago

+1

dieulot commented 4 years ago

Do you have a PageSpeed Insights URL where points are deducted because it’s not minified? I’ve never witnessed that myself.

dieulot commented 4 years ago

instant.page v2.0.1 has been released and it’s now minified.

MattWilcox commented 4 years ago

Sorry, only just seen this - nope, no examples as I've had to manually save, minify, and self-host the file every time it got flagged. Nice to see it now minified by default, thanks :)

kkmuffme commented 4 years ago

@dieulot just downloaded https://github.com/instantpage/instant.page/archive/v2.0.1.zip but there's no minified .js inside?

dieulot commented 4 years ago

From the repo you need to minify it yourself (see the readme). Otherwise grab the minified script at https://instant.page/2.0.1