search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.04k stars 205 forks source link

Progressive Enhancement #56

Closed aleemb closed 4 years ago

aleemb commented 4 years ago

Since this library has progressive enhancement, it would be good if you added a check for document.body.dataset and if it doesn't exist, then abort. That would prevent errors in any browsers that don't support dataset instead of error'ing out and halting the execution.

dieulot commented 4 years ago

This library is meant to be loaded as a module, so it can assume relatively decent JS support.