search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.04k stars 205 forks source link

t.target.closest is not a function #58

Closed kkmuffme closed 4 years ago

kkmuffme commented 4 years ago

As opened (but closed) here already https://github.com/instantpage/instant.page/issues/23 I also get this issue.

In 2.0.1 (using the .min version, it's o.target.closest) and also in 3.0.0

I am not exactly sure why/how, but I can provide a user agent that encountered this error: Mozilla/5.0 (iPhone, CPU iPhone OS 13_1_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.1 Mobile/15E148 Safari/604.1

The issue happened on a page which contained a facebook fbclid, but I don't think that is causing the issue (but who knows)

Is this info any useful for debugging/fixing this?

dieulot commented 4 years ago

Could you link to the page where that is happening?

kkmuffme commented 4 years ago

I have one, but I cannot reproduce it there (same user agent)

dmalis commented 4 years ago

Seeing these all the time; iOS, FBapp -> webview

kkmuffme commented 4 years ago

@dmalis great find

dieulot commented 4 years ago

Closing this as it’s a dupe or #23. If you have any more info please direct them there.

dieulot commented 2 years ago

This is fixed (with a check on event.target.closest) in v5.1.1. https://github.com/instantpage/instant.page/commit/00249af912beabe77ecd902ebcef190d698adc81