search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.04k stars 205 forks source link

Ignore links with onclick events #6

Closed lukencode closed 5 years ago

lukencode commented 5 years ago

Just a suggestion - I've been trying this out with a couple of legacy sites that do some dodgy stuff with onclick attributes. It is stuff like GET requests deleting resource but not until a confirm prompt.. Would checking for the onclick attribute and ignoring those links be useful?

dieulot commented 5 years ago

Click events might be used for something as simple as tracking clicks, so I don’t want to automatically disable those. I recommend using data-no-instant attributes on problematic links.