search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.01k stars 206 forks source link

v5.x causes pop-up windows in Firefox #72

Closed honzajavorek closed 10 months ago

honzajavorek commented 4 years ago

After upgrading to the latest version I got Firefox thinking my page spawns pop-up windows and blocking it. All I have is a link like this:

<a href="https://external-link.example.com/" rel="nofollow" target="_blank"></a>

When I click on it, it opens in a new tab, but the original page gets a yellow bar at the top saying Firefox has prevented 2 pop-up windows. When I allow Firefox to open this particular pop-up nevertheless, the same page opens for second time in a new tab.

I disabled all other JS on my page to verify there is no other interference. It is caused solely by the HTML I presented and instant.page v5.x. I can reproduce on both 5.0.0 and 5.0.1, but 3.0.0 is okay.

honzajavorek commented 2 years ago

It seems this has been somehow fixed? The issue doesn't seem to be present anymore after merging https://github.com/honzajavorek/junior.guru/pull/900. At least locally.

honzajavorek commented 10 months ago

Seems like fixed 💪