Scripts loads http not https

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%

https://instant.page

MIT License

6.04k stars 205 forks source link

Scripts loads http not https #8

Closed josefzacek closed 5 years ago

josefzacek commented 5 years ago

Visit https://www.jawaireland.ie/, hover over the header menu links. Insecure content blocked icon appears in search bar

bashbaugh commented 5 years ago

Try changing it to

<script src="https://instant.page/1.1.0" type="module" integrity="sha384-EwBObn5QAxP8f09iemwAJljc+sU+eUXeL9vSBw1eNmVarwhKk2F9vBEpaN9rsrtp"></script>

By the way, your website doesn't warn my (chrome) browser about "unsafe scripts"

josefzacek commented 5 years ago

@scitronboy I took the script from https://instant.page/ page which I believe is the latest version

batbyR commented 5 years ago

Hi @josefzacek!

Adding a trailing slash to your header menu links solved the problem on my machine.

<li class="nav-item">
  <a href="/models/" class="nav-link">Models</a>
</li>

Before:

After:

The prefetching requests are now successfull and insecure content warnings disappear.

You seem to force the trailing slash when visiting https://jawaireland.ie/models for example. Maybe it makes the prefecthing request fail. But I have not the root cause yet.

Tell me if this solution fixes the problem for you! 🤞

josefzacek commented 5 years ago

@batbyR hey Romain, thanks I mil for your help, it fixed the problem 👍🏾

Josef