search

instantpage / instant.page

Make your site’s pages instant in 1 minute and improve your conversion rate by 1%
https://instant.page
MIT License
6.05k stars 205 forks source link

Instant Page minified polluting scope #81

Closed alicescfernandes closed 4 years ago

alicescfernandes commented 4 years ago

We should have. a IIFE wrapped around this module to avoid reassigment of variables. If i use the non minified version, this doesn't happen, but when i use the minified version, i get this error:

image

With an IIFE this should be solved.

digitaljhelms commented 4 years ago

Fixed by https://github.com/instantpage/instant.page/pull/83

alicescfernandes commented 4 years ago

Thanks :+1: