instea / react-native-color-picker

Color picker component for IOS/Android
Apache License 2.0
272 stars 67 forks source link

Warning: Slider has been extracted from react-native core and will be removed in a future release #22

Open smartcris opened 4 years ago

smartcris commented 4 years ago

It can now be installed and imported from '@react-native-community/slider' instead of 'react-native'. See https://github.com/react-native-community/react-native-slider

sodik82 commented 4 years ago

you can use it now via sliderComponent props in 0.5.0

fritzfr commented 4 years ago

@sodik82 I am still getting a warning, even when I do provide this prop.

Screenshot 2020-02-05 at 12 58 08

My Code:

import { ColorPicker, toHsv, fromHsv } from 'react-native-color-picker';
import Slider from '@react-native-community/slider';
// ...

<ColorPicker
    sliderComponent={Slider}
    color={headColor}
    style={{ flex: 1 }} />
sodik82 commented 4 years ago

can you try with 0.5.1?

fritzfr commented 4 years ago

@sodik82 Yip, worked. Thanks!

fritzfr commented 4 years ago

@sodik82 Actually I have to reopen, the issue still persists. It was only gone shortly but the warning is back on every reload of my app. Same stack trace as above.

ridzwanari commented 2 years ago

same goes to me .. but when using trianglecolerpicker the error do not pop out when everytime I reload the app

@sodik82 Actually I have to reopen, the issue still persists. It was only gone shortly but the warning is back on every reload of my app. Same stack trace as above.

oleksii-jointoit commented 1 year ago

you can use it now via sliderComponent props in 0.5.0

Thanks, I added

import Slider from '@react-native-community/slider'; <ColorPicker sliderComponent={Slider} .. />

and it works

Jake-Mulhern commented 1 year ago

I made a post earlier saying that I had figured out how to add the react-native-community slider and then set the color on it by providing this as the sliderComponent

const renderSliderComponent = () => {
    return (
      <View>
        <Slider 
          minimumTrackTintColor={theme.colors.medium}
        />
      </View>
    )
  }

However, I realized that providing it this way changes the color of the slider but then the sliders stop working. Is there any props that I can add that would make it so that the sliders still work?

sodik82 commented 1 year ago

@Jake-Mulhern - you need to pass prop to the slider so that it can work

(props) => .... <Slider {...props} color="yellow"/>
Jake-Mulhern commented 1 year ago

you need to pass prop to the slider so that it can work

(props) => .... <Slider {...props} color="yellow"/>

@sodik82 when I pass {...props} in to the component it breaks the sliders. They are just stuck in the same location and won't move even if I don't pass the minimumTrackTintColor in as another prop.

When I log the props being passed in I get this.

{
  "onValueChange": [Function bound ],
  "value": 1,
}
Object {
  "onValueChange": [Function bound ],
  "value": 0.4823529411764706,
}