search

instea / react-native-color-picker

Color picker component for IOS/Android
Apache License 2.0
272 stars 67 forks source link

Marked props mentioned in #33 as optional #34

Closed artus9033 closed 3 years ago

artus9033 commented 3 years ago

Fixes #33

artus9033 commented 3 years ago

Also re-written the project in TypeScript for code readability and maintainability + added TS buildscripts

sodik82 commented 3 years ago

wau... need to check it out... not sure how linting will work now.....

artus9033 commented 3 years ago

Thanks for the notice, I forgot to check for Eslint compatibility; I updated the project to use eslint's monorepo solution for Typescript (https://github.com/typescript-eslint/typescript-eslint), then fixed the code to comply with style rules & pushed it altogether. Guess this should be sufficient for merging

artus9033 commented 3 years ago

@sodik82 will you merge now?

sodik82 commented 3 years ago

thanks for your work. I have take it as basis and released RC versions to see if there are any problems (and there was one). Now it looks stable and I have merged it to the master -> closing this MR now.

artus9033 commented 3 years ago

Thank you too, happy to have contributed!