instea / react-native-color-picker

Color picker component for IOS/Android
Apache License 2.0
272 stars 65 forks source link

Update HoloColorPicker.js #37

Closed Waleed065 closed 4 years ago

Waleed065 commented 4 years ago

This file uses react native slider. Slider was split out from the core of React Native. To migrate to this module you need to follow the installation instructions @https://github.com/react-native-community/react-native-slider and download react native slider and then change your imports from: import { Slider } from 'react-native';

to: import Slider from '@react-native-community/slider';

sodik82 commented 4 years ago

right now we don't have plans to switch to @react-native-community/slider as it requires installing native dependencies in RN (and as of now does not support web users).

therefore we have allowed users to simply pass sliderComponent as documented in Getting started.

to be honest I tried to "optionally" import @react-native-community/slider to provide sensible default but it always failed for users which don't want to install and use it but rather prefer another implementation.