Open Hektar90 opened 3 years ago
I have an issue too using '@react-native-community/slider' as sliderComponent. I don't get a crash but i think there is indeed an issue with the typechecking of sliderComponent props. Here's an extract of my code : <ColorPicker style={{ flex: 1 }} defaultColor={newColor} onColorChange={color => setNewColor(fromHsv(color))} // not working for now - seems to be an error in code of the package - see latest issue in package sliderComponent={(props: any) => ( <SliderComponent value={props.value} onValueCange={() => props.onValueChange()} /> )} />
My SliderComponent get the value prop. However, the onValueChange prop doesn't seem to work because when I slide, none of the "v" / "s" value are changing.
@Frakette Do you use typescript in your project? This is just a type error issue which means it compiles and works. Only my IDE is complaining.
SliderComponent isn't customized, is it? So just add the component class like so:
<ColorPicker ...sliderComponent={SliderComponent }
this should work if i get you right
@Hektar90 Yes I use typescript on my project. Actually my issue might not be fully related to yours but I also see a Typescript error when I try to add a sliderComponent.
I was struggling to pass props to my SliderComponent because I was passing it directly as a component and it was not working but as a function that returns a component it works although the slider is a bit glitchy.
However, as you noticed, I still get get the same Typescript error than you when passing SliderComponent. I ended up using a //@ts-expect-error to avoid compilation errors. But a correction on the type checking would be great :)
Any update in this issue? I have the same problem
I just want to use the default slider from '@react-native-community/slider'
adding this to the 'sliderComponent' prop results in an type error
Slider is an intersection type of React.Component