search

instea / react-native-color-picker

Color picker component for IOS/Android
Apache License 2.0
272 stars 67 forks source link

Import PropTypes package separately #6

Closed Ashoat closed 6 years ago

Ashoat commented 6 years ago

More recent versions of React Native are using React 16 beta, which has removed PropTypes from the main package. You have to use the separate prop-types package now.

Ashoat commented 6 years ago

I also updated the components to inherit from React.PureComponent, since it results in better performance, and based on my quick analysis the component is compatible with it.

sodik82 commented 6 years ago

thank you for the prop-type fix.

I will consider the PureComponent update as it might really help the performance for busy applications - although there is a slight chance that it won't work for some users as color property can be a object.

Ashoat commented 6 years ago

Ah! I didn't consider that. I can revert that change if you'd like, or you can edit this PR, or you can just push your own PropTypes fix - whatever works :)

sodik82 commented 6 years ago

No problem. Just give me a time to think about it. But I like the idea.

On 13 Sep 2017 23:55, "Ashoat Tevosyan" notifications@github.com wrote:

Ah! I didn't consider that. I can revert that change if you'd like, or you can edit this PR, or you can just push your own PropTypes fix - whatever works :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/instea/react-native-color-picker/pull/6#issuecomment-329308166, or mute the thread https://github.com/notifications/unsubscribe-auth/AF2SI99CVVyNq8iPEYkZNi2CUNjcdPHJks5siE9RgaJpZM4PWpi3 .