search

instea / react-native-popup-menu

Popup menu component for React Native
ISC License
1.48k stars 248 forks source link

Crash with Android 4.4, RN 0.63.0 #189

Open zwigglers opened 4 years ago

zwigglers commented 4 years ago

I get the following crash while using the v0.15.8 of the library with Android 4.4 and RN 0.63.0. The issue seems to be limited to Android 4. Error while updating property 'nativeBackgroundAndroid' of a view managed by: RCTView

This seems to be caused by the TouchableNativeFeedback component used by the makeTouchable method in helpers.js.

I managed to solve the problem by overriding the Touchable component used in MenuTrigger and MenuOption by doing customStyles={{ OptionTouchableComponent: TouchableHighlight }} or TriggerTouchableComponent for MenuTrigger

I found notes relating to the Android compatibility with TouchableNativeFeedback here: https://reactnative.dev/docs/touchablenativefeedback#ripple. But I can't find any use of TouchableNativeFeedback .Ripple or TouchableNativeFeedback .SelectableBackgroundBorderless in the react-native-popup-menu.

mashad6 commented 2 years ago

I am facing the same issue, any work around on this?