instedd / cdx

Connected Diagnostics Platform
https://cdx.io
9 stars 7 forks source link

Server error when trying to create Box without a purpose #1910

Closed ysbaddaden closed 1 year ago

ysbaddaden commented 1 year ago

Steps to reproduce:

Try to create a box without selecting a purpose and the server will respond with an INTERNAL SERVER ERROR message.

Culprits

  1. we don't display the error to the user alongside the form input (aka 'unhandled form error');
  2. the mechanism to report this warning to sentry crashes, we thus end-up reporting the crash to sentry instead of the unhandled form parameters (oops).

Log:

Unhandled form errors in Box: {:purpose=>["Purpose can't be blank", "Purpose is not included in the list"]}

Sentry issue RADX-CDX-10

sardar-usman commented 1 year ago

@ysbaddaden It's showing a proper error now. Working as expected.