Closed leandroradusky closed 1 year ago
There are no mockups for the reports and they were not used yet by users, said that the first table with the summary was modified to look like this since it looks better than before.
I don't quite get this. The design (better than mockups) for the table and reports is here and it had been already implemented. I'm not sure if it looks better... Anyhow, I say ship it as is, my observation is no blocker at all.
Hi @diegoliberman. Sorry because the name was misleading, here we're talking about the PDF exported for the samples report.
The second and third page looks quite the same, the first page now looks like this
As I mentioned above, what I decided to change is the summary, the first section. The Confussion Matrix section now looks slightly different than in the webpage because of the library that we use to generate the PDF report on the backend.
Let's chat if I'm not clarifying with this message :)
Made the fixes to display the confusion matrix exactly as on the website (as for the SVGs, the grays are not handled with transparencies ─as in the project's CSSs─ but with grey colors, which is a limitation of prawn but looks super similar). The styling now is made in subclasses of Prawn::Table::Cell
.
Also, the authenticity token problem was fixed with the form_tag
tag thanks to the guidance of @ysbaddaden (Thanks!! :bowing_man:)
I think I've addressed all the commentaries, if not, now let's sync :)
Thanks a lot for the guidance !!
Closes #1843 and #1900
Now, the samples reports are generated in the backend.
There are some slight changes in the look. The first page looks now like this:
Then the other two pages just contain the SVG files as they are downloaded.
For the sake of completeness, the ROC plot is also rendered OK, here is how it looks.
Some commentaries:
prawn-table
library: round borders are not supported and spaces between cells are managed with the borders, and painting borders will fill the full space between cells.Important (cc @julien, I need help in solving this): I'm posting the data in a newly created form, but I systematically get an
Invalid Authenticity Token
error which I don't know how to solve. I'm sure is a silly error but I didn't manage to solve it. Then I had to add the lineskip_before_action :verify_authenticity_token
which is only a transitory solution to make the feature to work.I've tested with a lot of different conditions:
All of them worked correctly for me, but this issue needs in-depth testing.
CC @diegoliberman