instedd / cdx

Connected Diagnostics Platform
https://cdx.io
9 stars 7 forks source link

New fields for batches entities (v2) #1987

Closed leandroradusky closed 10 months ago

leandroradusky commented 1 year ago

The fields in batches entities should include all missing fields in this table, since these properties will be exported in the NIH tables.

In my recollection these fields are:

Please note that these are the field numbers expressed in the table, when added into the batches entity, they shouldn't have the virus_ prefix on their name.

leandroradusky commented 1 year ago

@ysbaddaden Had comments on the implementation of this issue.

ysbaddaden commented 1 year ago

Unlike #1863 there is a lot of new attributes this time, for a total of 19 custom attributes, specific to a single extraneous feature (NIH tables generation).

We may want to look into the #custom_fields column of the Entity Framework. Maybe consider an additional, deployment-specific, field.yml for these custom attributes?

Then, only the NIH table templates would have knowledge of them.

:warning: notes: