instedd / hub

InSTEDD Hub
2 stars 4 forks source link

GoogleSpreadsheet should not be included as option in the list of Events #61

Closed mmuller closed 9 years ago

mmuller commented 9 years ago

Found in version ccff7a1

Having a GoogleSpreasheet connector Go to create a new Task Click 'Choose' from 'Events' Expand the options tree Search the name of the GoogleSpreadsheet Connector and select it Press the 'Select' button

Obtained: nothing happens Expected: Since GoogleSpreadsheet updates cannot be used as Event the Connector should not be included as option in the list of Events

screen shot 2014-12-12 at 4 07 13 pm

bcardiff commented 9 years ago

should not be included because it does not define events? that is not easy to compute before hand right now. If this is the reason I would suggest: wontfix

asterite commented 9 years ago

Maybe we can have a Connector define:

def has_events?
  true
end

def has_actions?
  true
end

Then each Connector can override it in case its sure there are no events/actions. In the case of Google Spreadsheet we would override it.

The same goes for each Entity/EntitySet in the code. That way we can show the user only what's necessary without unnecessary roundtrips to the server.

nditada commented 9 years ago

Partially solved for now.