Closed edjez closed 9 years ago
closed it by mistake
Add a 'delete' button for each parameter. @jkicillof did we have a design for this?
I think we should remove redundant elements first. There's no need for a CRUD list and a preview of the url and having both elements draggable pills. Also, it's a bit confusing having the parameter's name and parameter's value the same name. When a user adds a parameter, it's shown directly on the url like "new_parameter=new_parameter_value", on click becomes editable.
:+1: Perfect.
The "copy link" might not be that useful. Usually user will need to add some sort of authentication and replace argument values. I will vote for a "help" or "how to" that will explain how to invoke the action directly or from other InSTEDD apps via hub.
Also, notice that the external trigger name is missing in the url.
Copy link replaced and url fixed.
Will this also be applied to the step definition of the trigger? Or should I create a new issue? Right now if you make a mistake when dropping a pill the only way to go back is by deleting the step.
@juanboca I don't think so. There is style still pending to be applied to that box thou. But the @jkicillof proposal would not apply directly to add/remove hub's open struct fields.
Empty help page created at https://github.com/instedd/mbuilder/wiki/invoke_external_triggers
Ok in version 1.4-pre2
Can add external parameters by typing in a name but can't delete