search

instedd / mbuilder

Scalable SMS application builder
http://mbuilder.instedd.org/
6 stars 1 forks source link

Can't remove parameter in External Trigger #203

Closed edjez closed 9 years ago

edjez commented 9 years ago

Can add external parameters by typing in a name but can't delete

nditada commented 9 years ago

closed it by mistake

nditada commented 9 years ago

Add a 'delete' button for each parameter. @jkicillof did we have a design for this?

jkicillof commented 9 years ago

I think we should remove redundant elements first. There's no need for a CRUD list and a preview of the url and having both elements draggable pills. Also, it's a bit confusing having the parameter's name and parameter's value the same name. When a user adds a parameter, it's shown directly on the url like "new_parameter=new_parameter_value", on click becomes editable. application_externaltriggers_editor

nditada commented 9 years ago

:+1: Perfect.

bcardiff commented 9 years ago

The "copy link" might not be that useful. Usually user will need to add some sort of authentication and replace argument values. I will vote for a "help" or "how to" that will explain how to invoke the action directly or from other InSTEDD apps via hub.

Also, notice that the external trigger name is missing in the url.

jkicillof commented 9 years ago

Copy link replaced and url fixed. application_externaltriggers_editor

juanboca commented 9 years ago

Will this also be applied to the step definition of the trigger? Or should I create a new issue? Right now if you make a mistake when dropping a pill the only way to go back is by deleting the step. screen shot 2015-05-06 at 11 10 49 am

bcardiff commented 9 years ago

@juanboca I don't think so. There is style still pending to be applied to that box thou. But the @jkicillof proposal would not apply directly to add/remove hub's open struct fields.

bcardiff commented 9 years ago

Empty help page created at https://github.com/instedd/mbuilder/wiki/invoke_external_triggers

pmallol commented 9 years ago

Ok in version 1.4-pre2