search

instedd / mbuilder

Scalable SMS application builder
http://mbuilder.instedd.org/
6 stars 1 forks source link

Phone numbers stored as float fail later when sending SMS #331

Closed nditada closed 8 years ago

nditada commented 9 years ago

If sender phone numbers are stored in a table, mBuilders stores them as float. Using those numbers later to send SMS results in a Nuntium error when trying to send to a number like 12323234.0.

Steps to reproduce: create a trigger that subscribes a caller. drag and drop the sender phone number to a new empty table. create a periodic trigger that sends SMS to subscribers in that table. Test both triggers

result: messages do not go as nuntium can't send messages if the phone number has a trailing '.0'

expected: phone numbers should never be stored as float in an mbuilder table.

@mmuller can we automate a regression test please?

bcardiff commented 9 years ago

@nditada I was not able to repro this. I tried this mbuilder app and get this behaviour

screen shot 2015-09-02 at 12 28 48 pm

something else you can add to find the bug?

bcardiff commented 9 years ago

I narrowed it to periodic tasks that try to send bulk sms:

sending a message to all at once does not work

screen shot 2015-09-02 at 1 54 27 pm

sending them one by one it does

screen shot 2015-09-02 at 1 54 34 pm

recent activity

screen shot 2015-09-02 at 1 54 54 pm

would this be consistent with your experiments @nditada ?